Pros
The good thing about working at goodwill is the steady pay. I also worked with some friends I'd gone to high school with which was enjoyable. Typically, with two weeks notice, you will get whatever requested time off you need. So long as the dates you ask for are not too much or too often.
Cons
The managers at my location seemed to be on a power trip. Very often a manager would come up to you and ask you to preform one task, then a few minutes later ask for something else to be done. Normally that'd be no big deal, but later on that day you'd get scolded for an incomplete task regardless as to whether you pointed out that you weren't finished with your original assigned task before being moved elsewhere. I had a stalker follow me around my store that my managers did very little about. It wasn't until he left me a love letter that anything was taken seriously. Like any retail store customers can be quite a handful. I once had a video game thrown at me because our return policy didn't allow for them to be returned. I also knew of another girl who had the same thing happen to her only she got shoes thrown at her head.