Pros
The ability to serve your country and the dynamics of the working environment. The opportunity to travel and the ability to train in different jobs doing different things helps to break up the monotonoy of the same old routines found at many civilian jobs. The periodic of transfer of yourself and supervisiors can certainly be a good thing if your boss is hard to work with. The steady paycheck. Knowing that you will never make any less one month than another. The bonds that you forge with fellow soldiers that cannot be replicated anywhere else. The benefits of medical and dental service offered. Though not sterling are better than many places and best of all free. Not socalised as some would believe. As it is available only to military and dependents. Which has a certain appeal to help shore up the positive side of the coin of military life. Opportunity for advancement. It is overall easier to advance through your "corporate" ladder than in civilian life. All in all lot of pros.
Cons
Long hours. No over time pay. Inability to quit if you just really don't like your job. Not much individualism. Which creates an atmosphere of hostility sometimes if you don't fit into the big picture. No trial period really. If you don't like it your stuck with it until your contract date expires. The possibility of going to war. The lack of qualified people in positions of authority. Not all, but enough to cause a nuisance. The antiquated height/body fat index used to determine how much one can weigh for Physical Training purposes. The redundancy of things that seem to make everyone seem to be idiotic or inable to carry out the smallest tasks. Again not always but often enough to get under your skin.